fix: Twitter login notifications, incorrect cookie management. #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I highly recommend merge this before new release, required fix, also CI is failing: |
proteanx
approved these changes
Dec 22, 2024
monilpat
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
No issue.
Risks
LOW - could break logins, but I tested.
Background
I noticed multiple login notifications in twitter:
My previous changes were not fully correct.
What does this PR do?
Handles twitter cookies better in twitter without re-triggering
login()each time.What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Why are we doing this? Any context or related work?
I recently pushed: #1288
Not sure if my PR broke this, or was always issue, but now fixed, not getting notifications anymore with cached cookies.
Documentation changes needed?
My changes do not require a change to the project documentation.
I cleared cache and watch the twitter login notifications in app. No longer getting notifications of "new login".
Testing
Where should a reviewer start?
Try login twice with cached cookies and should see no more new login notifications.
Detailed testing steps
None, automated tests are fine.
Discord username
cjft