Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: {{user}} tags in templates/examples empty when passed to LLM #1305

Merged
merged 8 commits into from
Dec 24, 2024

Conversation

tcm390
Copy link
Collaborator

@tcm390 tcm390 commented Dec 21, 2024

related: #1267

截圖 2024-12-20 下午11 08 14

monilpat
monilpat previously approved these changes Dec 21, 2024
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of comment :)

packages/core/src/context.ts Show resolved Hide resolved
Base automatically changed from develop to main December 22, 2024 07:01
@shakkernerd shakkernerd dismissed monilpat’s stale review December 22, 2024 07:01

The base branch was changed.

@monilpat monilpat changed the base branch from main to develop December 24, 2024 01:57
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monilpat monilpat merged commit 6f61755 into develop Dec 24, 2024
6 checks passed
@monilpat monilpat deleted the tcm-compose-random-user branch December 24, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants