Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ENABLE_ACTION_PROCESSING logic #1268

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

oxSaturn
Copy link
Contributor

@oxSaturn oxSaturn commented Dec 20, 2024

Relates to:

Risks

Low

Background

Setting ENABLE_ACTION_PROCESSING=true in .env file won't work at the moment as parseBooleanFromText doesn't handle true value but YES, NO etc. per:

https://github.com/ai16z/eliza/blob/main/packages/core/src/tests/parsing.test.ts#L36-L52

What does this PR do?

Update the code so ENABLE_ACTION_PROCESSING would work as expected.

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

@oxSaturn oxSaturn marked this pull request as ready for review December 20, 2024 13:23
@odilitime
Copy link
Collaborator

note this also changes the default to off

@oxSaturn
Copy link
Contributor Author

note this also changes the default to off

It's set to false in .env.example https://github.com/ai16z/eliza/blob/main/.env.example#L70. Do we want to enable it by default?

@odilitime
Copy link
Collaborator

I'm checking with Dorian, we'll roll with this until he explains why someone would want it on vs off

@odilitime odilitime merged commit f3538d0 into elizaOS:develop Dec 20, 2024
2 of 4 checks passed
@oxSaturn oxSaturn deleted the fix/ENABLE_ACTION_PROCESSING branch December 21, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants