Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update env for plugin-goat #1180

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

aeither
Copy link
Contributor

@aeither aeither commented Dec 17, 2024

Relates to:

Risks

Background

What does this PR do?

Update ALCHEMY_API_KEY to EVM_PROVIDER_URL for plugin-goat
which is more accurate as user can provide any rpc URL. it is not an alchemy api key what needs to be provided

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

@aeither aeither changed the base branch from main to develop December 17, 2024 15:00
odilitime
odilitime previously approved these changes Dec 17, 2024
Copy link
Collaborator

@odilitime odilitime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to update the documentation

@odilitime odilitime changed the title update env for plugin-goat chore: update env for plugin-goat Dec 17, 2024
@aeither
Copy link
Contributor Author

aeither commented Dec 17, 2024

Will need to update the documentation

Where?

@odilitime
Copy link
Collaborator

search the repo for any mention of ALCHEMY_API_KEY

if none, at a bare minimum include the instructions of the plugin README

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monilpat monilpat merged commit d4c5419 into elizaOS:develop Dec 24, 2024
2 checks passed
1to3for5vi7ate9x pushed a commit to 1to3for5vi7ate9x/eliza that referenced this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants