-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update env for plugin-goat #1180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to update the documentation
Where? |
search the repo for any mention of ALCHEMY_API_KEY if none, at a bare minimum include the instructions of the plugin README |
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
82be6fb
to
df9f57f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chore: update env for plugin-goat
Relates to:
Risks
Background
What does this PR do?
Update ALCHEMY_API_KEY to EVM_PROVIDER_URL for plugin-goat
which is more accurate as user can provide any rpc URL. it is not an alchemy api key what needs to be provided
What kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps