Add permission and channel handling #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
approved these changes
Jul 24, 2023
Comment on lines
+62
to
+64
| chann_to_time: %{}, | ||
| chann_to_addr: %{}, | ||
| addr_to_chann: %{}, |
There was a problem hiding this comment.
wouldn't be it easier to merge this into one map?
There was a problem hiding this comment.
Wdym? I can at most merge chann_to_addr and chann_to_time, but it would make it less convinient imo. I need one map where keys are addresses when messages arrives from peer as UDP packets and one map where channel numbers are keys when ChannelData arrives from client. @mickel8
lib/ex_turn/allocation_handler.ex
Outdated
| %Type{class: :indication, method: :data} | ||
| |> Message.new([xor_addr, data]) | ||
| |> Message.encode() | ||
| |> then(&:gen_udp.send(state.turn_socket, c_ip, c_port, &1)) |
There was a problem hiding this comment.
Nitpick, but imo then is unredable
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.