runs chromedriver without a sandbox

[StefanoDeVuono]

On newer versions of MacOS, running wallaby with chromedriver causes the following warning:

chromedriver[nnnn:nnnnnn] pid(nnn)/euid(nnn) is calling TIS/TSM in non-main thread environment, ERROR : This is NOT allowed. Please call TIS/TSM in main thread!!!

Over and over again. On apple.com forums, I found that this is related to key events being sent to a secondary thread.

I noticed that for karma-chrome-launcher, the --no-sandbox flag seems to help in headless mode.

So, I'm submitting a PR to run chromedriver in headless mode by default with wallaby as well.

[mhanberg]

Is this related to #376 ?

[StefanoDeVuono]

@mhanberg Ostensibly, yes. But I'm running wallaby 0.20.0 and still getting those errors.

[keathley]

@StefanoDeVuono Thanks for the fix! This all LGTM. I'm curious if this was happening even on master or if the port change fixed it. Either way not opposed to this fix. Just curious.

[StefanoDeVuono]

@keathley I saw it on both 0.13.0 (which I think is from before that port change was merged in) and 0.20.0 (which is after). In your experience, the port change alone did the trick?

[keathley]

I think the port change is only on master. That doesn't mean that we shouldn't be using this though. I'm not sure what else the --no-sandbox flag changes for chromedriver.

[StefanoDeVuono]

@keathley Oh. Wouldn't putting version 0.20.0 is my mix.exs file use the master branch version of wallaby?

[keathley]

Ah! No it'll just pull the 0.20 tag from hex. You can try running it locally in order to see if it still outputs all the noise.

[StefanoDeVuono]

@keathley Whoa! How do I get the updated version in my mix file?

Lemme take a look. Maybe this PR is for naught!

Thanks for your help, btw

[keathley]

You can try swapping out the "~> 0.20" with something like git: "https://github.com/keathley/wallaby.git". I forget the exact magical incantation for that but its probably pretty close. The info is here: https://hexdocs.pm/mix/Mix.Tasks.Deps.html.

[StefanoDeVuono]

@keathley Yeah. I saw that. I'm new to elixir and I just assumed that updating the version number would download that version. Good to know!

Also, it works with {:wallaby, github: "keathley/wallaby", only: :test}

Thanks again. I'm closing this out.

[keathley]

No prob. Welcome to the community 😄

[StefanoDeVuono]

Oh, also, @keathley I noticed that version 0.20.0 came out around 11 April and PR 376 around 10 July

Two questions:

1. Would you accept a PR bumping wallaby to say 0.20.1 or 0.21.0?
2. Would putting that version in my mix.exs file get hex to download the current master once the version change PR is merged in?

[keathley]

We'll have to bump the version. I'll make sure that we don't have any breaking changes in this release and see if I can push a new version to hex 👍