fix(completions): correctly insert cursor position #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cursor was being inserted in a strange matter, which made the modified ast not have a `__cursor__()` function, so we couldn't find the cursor. Really, all we need to do is insert the cursor on its own line between the line. For example, if you were to put the cursor into the middle of this line of code ```elixir Enum.map(some_list, fn row -> end) ``` It would insert the cursor like so ```elixir Enum.map(some_list, fn row -> __cursor__() end) ``` Fixes #406
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cursor was being inserted in a strange matter, which made the
modified ast not have a
__cursor__()function, so we couldn't find thecursor.
Really, all we need to do is insert the cursor on its own line between
the line.
For example, if you were to put the cursor into the middle of this line
of code
It would insert the cursor like so
Fixes #406