-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version working with ecto 3 #224
Comments
Yeah unfortunately i have not had time to update the adapter to support ecto 3. It's on my backlog of things to do. I will hopefully get to it next week. |
Just curious about this. Is there a PR I can submit changes to (if it's there - I wouldn't know where to begin tbh). |
Just now seeing this. This does look like a bit of work but doable. I'll see if I can start picking at this. |
In case someone is waiting for this to happen, I've been actually working on this. You can observe the progress here: (Keep in mind that this code is a mess) Unfortunately, there is a lot to do. Some tests are failing from integrations tests. Some tests are failing from sqlite_ecto2. I had to add some changes to sqlitex (fork). I still need to go through all the commits in DbConnection,Ecto,EctoSql to make sure that nothing is missing. In short: a lot to do, hopefully it will be done within a few weeks. |
Any news on this front? |
Not on my end. |
Unfortunately, I had to postpone indefinitely this project. |
That happens! I recently have a bit of time now so I think I’ll look into this. It’s also a hard requirement now since I want to upgrade my use of Phoenix. (Originally published at: https://v2.jacky.wtf/post/f9348b3b-c441-4dfe-980c-9e9dfd335e3f) |
- Will allow more powerful ecto based queries TODO: - How is the order_updated_callback going to work? May not be possible to use `self`. Does BERT support it? Perhaps the Order struct doesn't have the field, only the submission does at it registers it in a lookup table by client_id - May be able to use sqlite3 instead soon??? elixir-sqlite/sqlite_ecto2#224 (comment) - Use etso if sqlite3 adapter still not ready - Fix broken tests - Remove old OrderStore DONE:
Hey all, I've got a use case for this, so I'd be interested in helping out. A bit busy right now on Selectrix/Mavis but I'll be doing Recurse Center soon, where I'll work on my use case, so this can be a major priority. @adamzapasnik do you have any soundbites on handoff from where you left off (does it seem like a straightforward migration? are there any show-stoppers that caused big blocks?) @jalcine did you make any headway tinkerincg on it? Also hi! It looks like you're really physically close, too bad there's SIP or I'd offer to meet up for coffee. |
I'm still working on my project's upgrade to Phoenix. |
no worries! I kinda started poking at it myself the other day. |
Following, I run a production system based on this library. It's holding up fine as it is for now, but would love to upgrade to Ecto 3. This project is a huge life saver, thank you for that. Without this library, I would probably re-writing everything from scratch myself which is NOT what I want to do. So, thank you again. |
Any news on this topic? I think I may be able to give a hand. What is the best starting point ? |
@jeanparpaillon check out #244 I'm currently digging in to this also as I have a need to for elixir to function with sqlite and I want to use ecto. |
Can be closed? Finally. |
It most definitely can. |
Hey there,
while trying to upgrade to phoenix 1.4 I get these two errors that are related to sqlite_ecto2 not being able to link to the new deps.
The text was updated successfully, but these errors were encountered: