Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version working with ecto 3 #224

Closed
razzeee opened this issue Nov 9, 2018 · 18 comments
Closed

Version working with ecto 3 #224

razzeee opened this issue Nov 9, 2018 · 18 comments

Comments

@razzeee
Copy link

razzeee commented Nov 9, 2018

Hey there,

while trying to upgrade to phoenix 1.4 I get these two errors that are related to sqlite_ecto2 not being able to link to the new deps.

Failed to use "db_connection" (versions 2.0.0 and 2.0.1) because
  postgrex (version 0.14.0) requires ~> 2.0
  sqlite_ecto2 (versions 2.3.0 and 2.3.1) requires ~> 1.1


Failed to use "ecto" (versions 3.0.0 and 3.0.1) because
  phoenix_ecto (version 4.0.0) requires ~> 3.0
  sqlite_ecto2 (versions 2.3.0 and 2.3.1) requires 2.2.9
@ConnorRigby
Copy link
Member

Yeah unfortunately i have not had time to update the adapter to support ecto 3. It's on my backlog of things to do. I will hopefully get to it next week.

@jalcine
Copy link
Contributor

jalcine commented Jan 29, 2019

Just curious about this. Is there a PR I can submit changes to (if it's there - I wouldn't know where to begin tbh).

@ConnorRigby
Copy link
Member

Unfortunately i haven't really had time to work on it.
here is a thread on updating to DBConnection 2.0
here is a changelog on what is required for Ecto 3

@jalcine
Copy link
Contributor

jalcine commented Mar 19, 2019

Just now seeing this.

This does look like a bit of work but doable. I'll see if I can start picking at this.

@ConnorRigby
Copy link
Member

@jalcine If you do get to this, the Ecto 2 branch will probably need to be brought up to the final version of Ecto2 first. This has been in progress here

@adamzapasnik
Copy link
Contributor

adamzapasnik commented Apr 22, 2019

In case someone is waiting for this to happen, I've been actually working on this.

You can observe the progress here: (Keep in mind that this code is a mess)
adamzapasnik@235e550

Unfortunately, there is a lot to do. Some tests are failing from integrations tests. Some tests are failing from sqlite_ecto2. I had to add some changes to sqlitex (fork). I still need to go through all the commits in DbConnection,Ecto,EctoSql to make sure that nothing is missing. In short: a lot to do, hopefully it will be done within a few weeks.

@kitplummer
Copy link

Any news on this front?

@jalcine
Copy link
Contributor

jalcine commented Mar 30, 2020

Not on my end.

@adamzapasnik
Copy link
Contributor

Any news on this front?

Unfortunately, I had to postpone indefinitely this project.

@jalcine
Copy link
Contributor

jalcine commented May 24, 2020

Unfortunately, I had to postpone indefinitely this project.

That happens! I recently have a bit of time now so I think I’ll look into this. It’s also a hard requirement now since I want to upgrade my use of Phoenix.

(Originally published at: https://v2.jacky.wtf/post/f9348b3b-c441-4dfe-980c-9e9dfd335e3f)

rupurt added a commit to fremantle-industries/tai that referenced this issue May 24, 2020
- Will allow more powerful ecto based queries

TODO:

- How is the order_updated_callback going to work? May not be possible
  to use `self`. Does BERT support it? Perhaps the Order struct doesn't
have the field, only the submission does at it registers it in a lookup
table by client_id
- May be able to use sqlite3 instead soon??? elixir-sqlite/sqlite_ecto2#224 (comment)
- Use etso if sqlite3 adapter still not ready
- Fix broken tests
- Remove old OrderStore

DONE:
@ityonemo
Copy link

Hey all, I've got a use case for this, so I'd be interested in helping out. A bit busy right now on Selectrix/Mavis but I'll be doing Recurse Center soon, where I'll work on my use case, so this can be a major priority. @adamzapasnik do you have any soundbites on handoff from where you left off (does it seem like a straightforward migration? are there any show-stoppers that caused big blocks?)

@jalcine did you make any headway tinkerincg on it? Also hi! It looks like you're really physically close, too bad there's SIP or I'd offer to meet up for coffee.

@jalcine
Copy link
Contributor

jalcine commented Nov 9, 2020

I'm still working on my project's upgrade to Phoenix.

@ityonemo
Copy link

no worries! I kinda started poking at it myself the other day.

@dsignr
Copy link

dsignr commented Jan 4, 2021

Following, I run a production system based on this library. It's holding up fine as it is for now, but would love to upgrade to Ecto 3. This project is a huge life saver, thank you for that. Without this library, I would probably re-writing everything from scratch myself which is NOT what I want to do. So, thank you again.

@jeanparpaillon
Copy link

Any news on this topic? I think I may be able to give a hand. What is the best starting point ?

@warmwaffles
Copy link
Member

@jeanparpaillon check out #244

I'm currently digging in to this also as I have a need to for elixir to function with sqlite and I want to use ecto.

@cw789
Copy link

cw789 commented Mar 22, 2021

Can be closed? Finally. ♥️ elixir-sqlite/ecto_sqlite3

@warmwaffles
Copy link
Member

It most definitely can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants