Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Ecto Adapter #1

Closed
wants to merge 6 commits into from
Closed

Adds Ecto Adapter #1

wants to merge 6 commits into from

Conversation

warmwaffles
Copy link
Member

No description provided.

@warmwaffles warmwaffles added the help wanted Extra attention is needed label Feb 19, 2021
@warmwaffles
Copy link
Member Author

I've been pouring over https://github.com/elixir-ecto/ecto_sql and https://github.com/elixir-ecto/ecto to figure out what callbacks need to be implemented.

I think the closes implementation we should probably look to would be the MySQL implementation. Rationale for that, myxql has to deal with similar issues sqlite has where we are missing the returning ability for insertion.

I don't think it is so important to support that feature.

In order to get something semi functional, I had to frankenstein this
together. The tests that come with ecto_sql are terrible and need to be
refactored as much as possible.
@warmwaffles
Copy link
Member Author

I think the worst part about the current set of adapters that exist within ecto_sql is that they are really hard to test. There are a bunch of private utility methods that are buried deep within the code and make it difficult to test and verify things.

I'm going to come up with something a little more manageable soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant