Fix/linear shapes #288
Merged
Fix/linear shapes #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msluszniak
approved these changes
Jul 14, 2024
josevalim
reviewed
Jul 15, 2024
josevalim
reviewed
Jul 15, 2024
Co-authored-by: José Valim <[email protected]>
Co-authored-by: José Valim <[email protected]>
Great, I'll update the docs |
josevalim
reviewed
Jul 28, 2024
| @@ -428,6 +428,8 @@ defmodule Scholar.Linear.BayesianRidgeRegression do | |||
|
|
|||
| @doc """ | |||
| Makes predictions with the given `model` on input `x`. | |||
| Output predictions have shape {n_samples} when train target is shaped either {n_samples} or {n_samples, 1}. | |||
There was a problem hiding this comment.
We should start a new paragraph, because the first paragraph should always be a short summary. And use backticks around code, can you please apply similar changes below? :)
Suggested change
| Output predictions have shape {n_samples} when train target is shaped either {n_samples} or {n_samples, 1}. | |
| Output predictions have shape `{n_samples}` when train target | |
| is shaped either `{n_samples}` or `{n_samples, 1}`. |
There was a problem hiding this comment.
Sure thing. Thank you for your comments.
josevalim
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the changes proposed here
Please note the changes to
test/scholar/linear/bayesian_ridge_regression_test.exsto fully understand the scope of the changes.On the above comment, I defended models being equal when fitting single column vectors and one dimensional vectors.
However, I've just thought a drawback to this approach.
If the output of
.predictis the same on both input cases, this means that prediction and target shapes may be different. This can cause some inconveniences.I still think this is the better approach, but I want to make clear that the change is significant.