Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exla): add LU custom_call #1549

Merged
merged 3 commits into from
Oct 29, 2024
Merged

feat(exla): add LU custom_call #1549

merged 3 commits into from
Oct 29, 2024

Conversation

polvalente
Copy link
Contributor

Adds a CPU custom call for Nx.LinAlg.lu, as that function is needed for Nx.LinAlg.determinant

@polvalente
Copy link
Contributor Author

This is related to, but doesn't fully solve, #1388

@polvalente polvalente self-assigned this Oct 29, 2024
Copy link
Collaborator

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess for the GPU we can always transfer it back to CPU, do the work, and place it on the GPU again.

@polvalente
Copy link
Contributor Author

@josevalim yeah, that solves most of the problem already. Having the defn definition would be a lot better, so that's why I don't want to close the issue.

@polvalente polvalente merged commit 7af065e into main Oct 29, 2024
7 of 8 checks passed
@polvalente polvalente deleted the pv-feat/custom-callback-lu branch October 29, 2024 18:20
josevalim added a commit that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants