(Experimental) Integrate Metal PjRt plugin #1504
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
force-pushed
the
jk-s32
branch
from
2f3c6ef to
6cc049f
Compare
NickTaylor-
reviewed
Oct 20, 2024
|
|
||
| wheel_path = Path.join(xla_extension_path, "jax_metal.whl") | ||
|
|
||
| {_, 0} = System.shell("wget --output-document=#{wheel_path} #{wheel_url}") |
There was a problem hiding this comment.
wget isn't available in macOS by default, and the default PATH in livebook doesn't include Homebrew's /bin (that might be my own setup), so it would be more portable if this was curl.
There was a problem hiding this comment.
Yes, this is just a proof of concept, this would be moved and downloaded as part of elixir-nx/xla :)
jonatanklosko
force-pushed
the
jk-mps
branch
from
8a851f1 to
5a50406
Compare
|
(I pushed an update to reduce the diff, in case someone wants to look into another PjRt plugin integration) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates the PjRt plugin from the
jax-metalfor running on the Apple GPU. To test it, one can setclient: :mpson EXLA backend/compiler. Since the plugin is loaded as a separate dynamic library, it can be tested without any changes to XLA (just make sure to remove thecache/directory).Certain computations can already be run, but the plugin is still very much incomplete. This PR is a room for experimentation and is meant to track the plugin progress. I reported a number of issues upstream, comments in the code point to those. In a few places I applied workarounds as temporary solutions or just to avoid VM crashes (segfaults), those are marked with a TODO.
Issues
For tracking purposes, here is a list of the Metal plugin issues reported upstream:
Crucial
jax.lax.while_loopjax-ml/jax#21552Not implemented
Edge cases
jax.lax.dynamic_update_slicejax-ml/jax#21392All issues: link.
Note: this PR is against the jk-s32 branch, which changes the default integer precision to 32 bits. This is a planned change (#1491), but it's not integrated yet to avoid conflicts with other work in progress.