Do not trap tab in search bar

elixir-lang · Dec 21, 2024 · edd69be · edd69be
1 parent 77e674d
commit edd69be
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 59 deletions.
diff --git a/assets/js/search-bar.js b/assets/js/search-bar.js
@@ -80,7 +80,7 @@ function addEventListeners () {
     } else if (event.key === 'ArrowDown' || (appleOS && event.ctrlKey && event.key === 'n')) {
       moveAutocompleteSelection(1)
       event.preventDefault()
-    } else if (event.key === 'Tab') {
+    } else if (event.key === 'Tab' && selectedAutocompleteSuggestion() !== null) {
       togglePreview()
       event.preventDefault()
     }

diff --git a/formatters/html/dist/html-ZOXW4WH5.js b/formatters/html/dist/html-ZOXW4WH5.js
diff --git a/lib/ex_doc/formatter/html/templates/sidebar_template.eex b/lib/ex_doc/formatter/html/templates/sidebar_template.eex
@@ -75,8 +75,8 @@
             <span class="sr-only">Search documentation of <%= config.project %></span>
             <input name="q" type="text" class="search-input" placeholder="Press / to search" autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false" />
           </label>
-          <button type="submit" class="search-button" aria-label="Submit Search">
-            <i class="ri-search-2-line ri-lg" aria-hidden="true" title="Submit search"></i>
+          <button type="submit" class="search-button" aria-label="Submit Search" tabindex="-1">
+            <i class="ri-search-2-line ri-lg" aria-hidden="true"></i>
           </button>
           <button type="button" tabindex="-1" class="search-close-button" aria-hidden="true">
             <i class="ri-close-line ri-lg" title="Cancel search"></i>