Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Remove Xgit.Util.FileSnapshot. #286

Merged
merged 1 commit into from
Jan 19, 2020
Merged

Remove Xgit.Util.FileSnapshot. #286

merged 1 commit into from
Jan 19, 2020

Conversation

scouten
Copy link
Collaborator

@scouten scouten commented Jan 19, 2020

Changes in This Pull Request

This need is better served by Xgit.Util.ObservedFile.

This allows us to remove the dependency on ConCache.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • There is test coverage for all changes. n/a
  • All cases where a literal value is returned use the cover macro to force code coverage. n/a
  • Any code ported from jgit maintains all existing copyright and license notices. n/a
  • If new files are ported from jgit, the path to the corresponding file(s) is included in the header comment. n/a
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment. n/a

This need is better served by Xgit.Util.ObservedFile.

This allows us to remove the dependency on ConCache.
@scouten scouten self-assigned this Jan 19, 2020
@codecov
Copy link

codecov bot commented Jan 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a4963b4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #286   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     29           
  Lines             ?   1461           
  Branches          ?      0           
=======================================
  Hits              ?   1461           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4963b4...89d3825. Read the comment docs.

@scouten scouten merged commit 65bddb9 into master Jan 19, 2020
@scouten scouten deleted the remove-file-snapshot branch January 19, 2020 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant