This repository has been archived by the owner on Oct 8, 2020. It is now read-only.
[API BREAKING] Add configuration APIs to Xgit.Repository.Storage behaviour. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 31 +1
Lines 1642 1690 +48
=========================================
+ Hits 1642 1690 +48
Continue to review full report at Codecov.
|
scouten
changed the title
scouten
force-pushed
the
storage+config
branch
from
5d99e21 to
139429c
Compare
scouten
force-pushed
the
storage+config
branch
from
b8b51d0 to
22397f2
Compare
Backing up a bit as this interface is unnecessarily complex.
* master: [API BREAKING] Replace Xgit.ConfigFile.add_entries/3 with ConfigFile.update/3. (#303)
Reading the git config CLI spec more closely, we don't need the ability to add multiple entries at once. This makes the implementation much simpler.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in This Pull Request
This adds Storage-level support for config files.
This is marked [API BREAKING] because it imposes new requirements on implementations of
Xgit.Repository.Storage.Checklist
covermacro to force code coverage.Any code ported from jgit maintains all existing copyright and license notices.n/aIf new files are ported from jgit, the path to the corresponding file(s) is included in the header comment.n/aAnyn/aTO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.