This repository has been archived by the owner on Oct 8, 2020. It is now read-only.
Transfer responsibility for enforcing tag target type to Xgit.Repository.Plumbing. #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce the requirement that the target object be a commit.
…at the target object is a commit.
scouten
added a commit
that referenced
this pull request
Jan 8, 2020
* master: Transfer responsibility for enforcing tag target type to Xgit.Repository.Plumbing. (#279)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in This Pull Request
Previously,
Xgit.Repository.Storage.put_ref/3verified that the target object was of typecommit. This caused a problem with the upcoming implementation ofXgit.Repository.tag/4, which needed to be able to write atagobject and have that pointed to by the ref.This PR moves that enforcement to
Xgit.Repository.Plumbing.update_ref/4.Checklist
covermacro to force code coverage.Any code ported from jgit maintains all existing copyright and license notices.n/aIf new files are ported from jgit, the path to the corresponding file(s) is included in the header comment.n/aAnyn/aTO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.