Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

[API BREAKING] Replace {:error, :invalid_repository} response with error. #264

Merged
merged 5 commits into from
Dec 20, 2019

Conversation

scouten
Copy link
Collaborator

@scouten scouten commented Dec 19, 2019

Changes in This Pull Request

IMHO passing a PID that is not a Repository process is a developer error, and should be treated as such.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • There is test coverage for all changes.
  • All cases where a literal value is returned use the cover macro to force code coverage. n/a
  • Any code ported from jgit maintains all existing copyright and license notices. n/a
  • If new files are ported from jgit, the path to the corresponding file(s) is included in the header comment. n/a
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment. n/a

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #264 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
- Coverage     100%   99.92%   -0.08%     
==========================================
  Files          27       27              
  Lines        1346     1336      -10     
==========================================
- Hits         1346     1335      -11     
- Misses          0        1       +1
Impacted Files Coverage Δ
lib/xgit/repository/plumbing.ex 99.37% <100%> (-0.63%) ⬇️
lib/xgit/repository/working_tree.ex 100% <100%> (ø) ⬆️
lib/xgit/repository/storage.ex 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d54a9...b27a192. Read the comment docs.

@scouten scouten merged commit 6a9eed9 into master Dec 20, 2019
@scouten scouten deleted the invalid-repository-error branch December 20, 2019 06:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant