Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

[API BREAKING] Xgit.Repository.put_ref/4: Add :follow_link? option. #250

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

scouten
Copy link
Collaborator

@scouten scouten commented Dec 3, 2019

Changes in This Pull Request

With follow_link?: false, it will be possible to update an existing symbolic ref.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • There is test coverage for all changes.
  • All cases where a literal value is returned use the cover macro to force code coverage.
  • Any code ported from jgit maintains all existing copyright and license notices. n/a
  • If new files are ported from jgit, the path to the corresponding file(s) is included in the header comment. n/a
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

With `follow_link?: false`, it will be possible to update an existing symbolic ref.
@scouten scouten self-assigned this Dec 3, 2019
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #250 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #250   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          38     38           
  Lines        1330   1332    +2     
=====================================
+ Hits         1330   1332    +2
Impacted Files Coverage Δ
lib/xgit/repository/test/ref_test.ex 100% <ø> (ø) ⬆️
lib/xgit/repository.ex 100% <ø> (ø) ⬆️
lib/xgit/repository/in_memory.ex 100% <100%> (ø) ⬆️
lib/xgit/repository/on_disk.ex 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506a667...b1a0926. Read the comment docs.

@scouten scouten changed the title Xgit.Repository.put_ref/4: Add :follow_link? option. [API BREAKING] Xgit.Repository.put_ref/4: Add :follow_link? option. Dec 3, 2019
@scouten scouten merged commit 80a4179 into master Dec 3, 2019
@scouten scouten deleted the put_ref+follow_link branch December 3, 2019 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant