-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpolation Behaviour Message Format #295
Interpolation Behaviour Message Format #295
Conversation
Hi @maennchen, thanks for the PR! I believe the changes could be simpler. Change |
@josevalim Wouldn't that mean, that no messages would be purged if extracting with another interpolator? (Calling Is it ok to use the backend config in extraction? If yes: why are there configs via the |
The configs in mix.exs are because we don't know what are the backends until that moment, iirc. |
@maennchen should we use another flag for auto generated? What does gettext use? |
@josevalim I'm not aware if gettext itself does something like that. It seems like there's no (documented) flag for that: https://www.gnu.org/software/gettext/manual/html_node/PO-Files.html#index-msgstr |
But I think we can just make one up as long as we prefix it. (To make sure it doesn't collide) Something like If you would want to go down that path, I would also offer a PR and do that before this PR. |
Let's go with elixir-generated, yeah. 👍 |
495cb34
to
cb53d85
Compare
e2e0be3
to
557e4f1
Compare
557e4f1
to
b36bb7e
Compare
Can you please rebase? And then I think this should be good! |
b36bb7e
to
042e696
Compare
@josevalim Done |
💚 💙 💜 💛 ❤️ |
Implements #294
Merge #296 first
This is only a draft and not a final implementation.
It looks like it is expected to configure the extract via the
mix.exs
options and not via the backend. Why is that?If we actually went this way, it would probably make more sense to yield the format when extracting. This way the extractor itself would not need to know about what format to use.