Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function clause for %FSS.HTTP.Entry{} #992

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

billylanchantin
Copy link
Contributor

@billylanchantin billylanchantin commented Sep 24, 2024

Closes: #991

{:ok, entry} = FSS.HTTP.parse("https://huggingface.co/datasets/aqubed/kub_tickets_small/resolve/main/data/train-00000-of-00001-47868532d4f55873.parquet")

Explorer.DataFrame.from_parquet!(entry)
# #Explorer.DataFrame<
#   Polars[1099 x 11]
#   number s64 [120202, 120201, 120200, 120198, 120197, ...]
#   ...
# >

@josevalim josevalim requested a review from philss September 24, 2024 14:43
Copy link
Member

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But would you mind to add a test case for that? I realize we only added cases for the URL as input. We can add only for parquets at the test/explorer/data_frame/parquet_test.exs file.

Copy link
Member

@philss philss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@billylanchantin billylanchantin merged commit ee0d4ae into main Sep 24, 2024
3 checks passed
@billylanchantin billylanchantin deleted the bl-add-fss-http-clause branch September 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_parquet does not handle explicit FSS.HTTP.Entry
2 participants