Improve performance of "concat_columns" #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to optimize #937
This is a different approach that consumes less memory and is faster. There is a small change in behaviour, which is the following: now we can concat DFs of different heights. The smaller columns will be filled with `nil` values.
philss
changed the title
josevalim
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation of "concat_columns" for lazy and eager dataframes.
Before this we were doing a join of a temporary column which consumes a lot of memory and is slower than concatenating each column of the DFs.
There is a small change in behaviour for lazy frames, causing frames of different sizes to be merged with
nilvalues for the smaller columns.Closes #937