Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement message-on-gc NIFs in Rust #936

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

filmor
Copy link
Contributor

@filmor filmor commented Jun 30, 2024

  • Pure Rust implementation of LocalMessage
  • Bump Rustler to 0.34.0
  • Drop explicit NIF list and on_load callback as these are now handled by Rustler implicitly

@filmor
Copy link
Contributor Author

filmor commented Jun 30, 2024

@josevalim The issue is actually the missing env parameter on the destructor. If it's okay with everyone here, I'd keep this PR open until this is fixed upstream in Rustler.

@josevalim
Copy link
Member

No issues with keeping it open!

@filmor filmor force-pushed the message-gc-rust branch 2 times, most recently from 186ecf2 to c0acc22 Compare July 9, 2024 16:39
@filmor filmor force-pushed the message-gc-rust branch from c0acc22 to 72b18e5 Compare July 9, 2024 17:04
@filmor filmor marked this pull request as ready for review July 9, 2024 17:04
@filmor
Copy link
Contributor Author

filmor commented Jul 9, 2024

This not only implements the function in pure Rust (thus making explorer pure Rust again), it also makes use of other niceties to trim down lib.rs quite massively. If you would like to limit the impact of this PR to the destructor addition, let me know.

@cocoa-xu
Copy link
Member

cocoa-xu commented Jul 9, 2024

This not only implements the function in pure Rust (thus making explorer pure Rust again), it also makes use of other niceties to trim down lib.rs quite massively. If you would like to limit the impact of this PR to the destructor addition, let me know.

Sorry this is off-topic but it looks really coool that we can just do rustler::init!("Elixir.Explorer.PolarsBackend.Native"); in rustler v0.34!

@josevalim josevalim merged commit 65fc464 into elixir-explorer:main Jul 9, 2024
4 checks passed
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

@filmor filmor deleted the message-gc-rust branch July 10, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants