Ps bump polars to v0.36 #798
Conversation
|
I am not sure if i have to merge to ps-bump-polars-to-v0.36 or main. Anyways marked the PR as draft. |
|
7 test cases are failing :
I have fixed test cases for nan comparison as Polars made a breaking change and we can't do much as we are just wrapping. Same with quantile function, they have made breaking changes with quantile function. They went with round even for reducing bias. Implemented window median function. I will hopefully complete implementing describe function in a couple of days. Join has breaking change, "outer_coalse" is for compatibility of existing behaviour and "outer" is little different now. We will just port to same behaviour ? Also the inspect node PR is causing PolarError ? |
|
@lkarthee thank you for your work here! I think we can point to
Let's port to the new behaviour, as José said in the issue :)
I didn't get it. What inspect? |
Jose clarified it is not. I will look more into Polars join func. I was thinking #784 was causing failure in outer join case. |
|
@philss I have pointed merge to https://github.com/elixir-explorer/explorer/tree/ps-bump-polars-to-v0.36 . |
|
@lkarthee sweet! I'm going to merge you work to that branch, so please open new PRs if you start to work on anything new. |
philss
merged commit 8930677
into
elixir-explorer:ps-bump-polars-to-v0.36
* WIP: bump polars to v0.36 --skip-ci * Ps bump polars to v0.36 (#798) * change counts to count * fix nan comparision * fix window_median & quantile * Fix outer join with Polars v0.36 (#802) * Bump to v0.36.0 - implement describe function (#803) * fix describe * review changes * implement describe in elixir * Update lib/explorer/data_frame.ex --------- Co-authored-by: lkarthee <[email protected]> Co-authored-by: José Valim <[email protected]>
#797
Continuing the work of @philss