Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ddof on covariance #747

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Expose ddof on covariance #747

merged 1 commit into from
Nov 30, 2023

Conversation

cigrainger
Copy link
Member

@cigrainger cigrainger commented Nov 29, 2023

Completes #743

I've got a couple failing tests but won't be able to get to it right away.

@philss
Copy link
Member

philss commented Nov 30, 2023

I think one of the failures it's because we are transforming every argument in an expression. Maybe we need to do just like we did with correlation here:

def to_expr(%LazySeries{op: :correlation, args: [series1, series2, ddof]}) do
, and have a custom implementation.

The other test is just the arity, for what I could understand.

@cigrainger cigrainger force-pushed the cg/expose-ddof-covariance branch from 78d9591 to 20e8d5e Compare November 30, 2023 08:56
@cigrainger
Copy link
Member Author

I think one of the failures it's because we are transforming every argument in an expression. Maybe we need to do just like we did with correlation here:

def to_expr(%LazySeries{op: :correlation, args: [series1, series2, ddof]}) do

, and have a custom implementation.
The other test is just the arity, for what I could understand.

Yes! Just realised that then saw your comment. Would have saved me a little bit 😂. Anyway should pass now. Thanks!

@cigrainger cigrainger merged commit d351fbe into main Nov 30, 2023
4 checks passed
@cigrainger cigrainger deleted the cg/expose-ddof-covariance branch November 30, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants