Add support for grouping into series #741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks!
My first intention with this PR was to implement implode to allow gathering all the values of a given group into a Series. Halfway through it, I noticed I was getting some double wrapping (i.e.
[[[1, 2]], [[3, 4]]]
instead of[[1, 2], [3, 4]]
).Then I looked a bit further and noticed there isn't really a need for
implode
to have this feature, we just need to allow plain lazy series in summarize and it just works, which is the approach this PR follows. I also updated the docs to reflect that.Please let me know if there's something I'm overlooking with this PR, or if this is not a wanted feature. I'm more than happy to start this over with a different approach or just scrap it altogether 🙂