add Series.cut/6 and Series.qcut/6 #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jun 27, 2023
lib/explorer/series.ex
Outdated
| iex> Explorer.Series.cut(s, [1.5, 2.5]) | ||
| #Explorer.DataFrame< | ||
| Polars[3 x 3] | ||
| float [1.0, 2.0, 3.0] |
There was a problem hiding this comment.
Suggested change
| float [1.0, 2.0, 3.0] | |
| float [1.0, 2.0, 3.0] |
There was a problem hiding this comment.
That makes the doctest fail. I think it's because it's a column named with an empty string due to this.
I'll rename it to values.
josevalim
approved these changes
Jun 27, 2023
|
Since José approved the changes, I'll mark this PR as ready for review. Cheers! |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @josevalim and @philss. I completely understand if you may not want to merge this, but I've given it a good go, and I thought I might as well submit a PR.
I've been eyeing these functions just because they're quite useful for exploratory data analysis and feature engineering - it's based on cut and qcut.
A couple of reason why we may not want to merge this:
polars-algoinCargo.toml. I'm honestly not sure what the implication of this is - bloating the NIFs perhaps?qcutis still experimental in Polars but also perhaps worth mentioning that it's been in Pandas for four years.