Percentiles for describe #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Dec 28, 2022
lib/explorer/data_frame.ex
Outdated
| @@ -4443,10 +4444,10 @@ defmodule Explorer.DataFrame do | |||
| """ | |||
| @doc type: :single | |||
| @spec describe(df :: DataFrame.t()) :: DataFrame.t() | |||
| def describe(df) do | |||
| def describe(df, percentiles \\ @default_percentiles) do | |||
There was a problem hiding this comment.
Let's make this an option, as we will likely have other percentiles in the future!
There was a problem hiding this comment.
Note we only need to make it an option here. It does not have to be an option in the behaviour.
added 2 commits
December 28, 2022 15:42
|
💚 💙 💜 💛 ❤️ |
liamdiprose
pushed a commit
to liamdiprose/explorer
that referenced
this pull request
Feb 16, 2023
Add support for large integers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.