Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add s_nil_count #446

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Add s_nil_count #446

merged 4 commits into from
Dec 5, 2022

Conversation

cristineguadelupe
Copy link
Contributor

No description provided.

@josevalim
Copy link
Member

Thank you @cristineguadelupe! I have a couple questions:

  1. Wouldn't it be better to expose it as Series.null_count instead of the data frame? I would say it would be better because we would be able to use it in more situations (including queries).

  2. Should this be called null_count or nil_count to mirror Elixir? Series has functions like drop_nil and is_nil... so I think it should be nil_count.

@cristineguadelupe cristineguadelupe changed the title Add DF null_count Add s_nil_count Dec 5, 2022
@philss
Copy link
Member

philss commented Dec 5, 2022

@cristineguadelupe awesome! Thank you! 💜

@philss philss merged commit 1d5dd8a into elixir-explorer:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philss philss philss approved these changes

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristineguadelupe @josevalim @philss