Allow Explorer.PolarsBackend.Series.pow/2 on (series, series) #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philss
reviewed
Nov 29, 2022
|
|
||
| let s = iter1 | ||
| .zip(iter2) | ||
| .map(|(v1, v2)| v1.unwrap().pow(v2.unwrap())) |
There was a problem hiding this comment.
Is it possible for one of values to be nil/null? Could you add a test for that if so?
| let iter2 = s1.u32()?.into_iter(); | ||
|
|
||
| let s = iter1 | ||
| .zip(iter2) |
There was a problem hiding this comment.
What happens if the series is different in size?
|
I'm merging this and I should fix the issues that I pointed :) |
liamdiprose
pushed a commit
to liamdiprose/explorer
that referenced
this pull request
Feb 16, 2023
Support more generalized macro for enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #375.
Because of my lack of Rust knowledge, I need feedback for the
s_pow/2code.