Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to_* functions to return only :ok #352

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

Ian-GL
Copy link
Contributor

@Ian-GL Ian-GL commented Sep 13, 2022

Changing the to_* functions to write to files on the Dataframe module to just return :ok on success (as the filename is an already an input of the function).

Closes #347

@josevalim josevalim merged commit deaaaec into elixir-explorer:main Sep 13, 2022
@josevalim
Copy link
Member

💚 💙 💜 💛 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_* functions should just return :ok
2 participants