Skip to content

Commit

Permalink
Fix warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
josevalim committed Nov 27, 2024
1 parent 9519021 commit 38dc33d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 23 deletions.
22 changes: 0 additions & 22 deletions lib/explorer/backend/query_frame.ex
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ defmodule Explorer.Backend.QueryFrame do
resource: reference() | nil
}

@behaviour Access
@behaviour Backend.DataFrame

@doc false
Expand Down Expand Up @@ -116,25 +115,4 @@ defmodule Explorer.Backend.QueryFrame do
"""
end
end

@impl Access
def fetch(%__MODULE__{} = lazy_frame, name) do
case pull(lazy_frame, name) do
%Explorer.Series{data: %Explorer.Backend.LazySeries{}} = lazy_series ->
{:ok, lazy_series}

_other ->
:error
end
end

@impl Access
def get_and_update(%__MODULE__{}, _name, _callback) do
raise "cannot update an `Explorer.Backend.QueryFrame`"
end

@impl Access
def pop(%__MODULE__{}, _name) do
raise "cannot delete from an `Explorer.Backend.QueryFrame`"
end
end
3 changes: 2 additions & 1 deletion test/explorer/data_frame_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -4742,8 +4742,9 @@ defmodule Explorer.DataFrameTest do
# deemed necessary.
# * For local development, remember to include property tests with the tag
# `--include property`.
@tag timeout: :infinity
describe "properties" do
@describetag timeout: :infinity

property "should be able to create a DataFrame from valid rows" do
check all(
dtypes <- Explorer.Generator.dtypes(),
Expand Down

0 comments on commit 38dc33d

Please sign in to comment.