Guide methods #177
Merged
Guide methods #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need to apologise! Thank you for the work! |
|
This PR is ready for review, but I saw a few failures that appeared unrelated to this PR. |
|
Great. Very appreciated. I'll check it out in a few weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Elio,
Apologies for putting in multiple PRs to your packages!
This is again a PR to keep guides compatible with the development version of ggplot2. In this case, there were just some missing methods that have been removed from ggplot2.
It's a work in progress (WIP) as I'm still figuring out what changes would be needed upstream in ggplot2 to make as many S3 guides compatible as I reasonably can.
Best,
Teun