Resolve #289 Find similar students #316
Conversation
| */ | ||
| public synchronized void findAndMergeSimilarStudents(){ | ||
| Log.i(getClass().getName(), "findAndMergeSimilarStudents"); | ||
| PreProcessorFactory ppF = new PreProcessorFactory(context); | ||
| TensorFlow tensorFlow = getInitializedTensorFlow(); | ||
| findSimilarStudentsUsingAvatarImages(ppF, tensorFlow); |
There was a problem hiding this comment.
Does an avatar image also include those taken manually in the fall-back registration activity? If so, you currently get a mix between 180px and 224px images. Will this inconsistency in image size/format cause problems?
There was a problem hiding this comment.
No, because our library uses the default value 224 for resizing the image to 224 x 224 if no sharedPreference with the key "key_faceSize" exists (this key doesn't exist in our app because we don't have the Settings from the library included)
| * @param tensorFlow | ||
| */ | ||
| private synchronized void findSimilarStudentsUsingAvatarImages(PreProcessorFactory ppF, TensorFlow tensorFlow){ | ||
| // Iterate through all Students | ||
| List<Student> students = studentDao.loadAll(); |
There was a problem hiding this comment.
Add logging here so that we can see if the method was triggered
Log.i(getClass().getName(), "findSimilarStudentsUsingAvatarImages");
| * @param tensorFlow | ||
| */ | ||
| private synchronized void findSimilarStudentsUsingMeanFeatureVector(PreProcessorFactory ppF, TensorFlow tensorFlow){ | ||
| // Iterate through all StudentImageCollectionEvents |
There was a problem hiding this comment.
Add Log.i(getClass().getName(), "findSimilarStudentsUsingMeanFeatureVector");
| @@ -365,5 +413,6 @@ public synchronized void findAndMergeSimilarStudents(){ | |||
| */ | |||
| private synchronized void mergeSimilarStudents(Student student1, Student student2){ | |||
| Log.i(getClass().getName(), "mergeSimilarStudents: student1: " + student1.getUniqueId() + " student2: " + student2.getUniqueId()); | |||
| // TODO Implement merging of students (maybe in another class like StudentMergeHelper) | |||
There was a problem hiding this comment.
This will be implemented in #314
No description provided.