Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more specific regex for babel-register #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use more specific regex for babel-register #18

wants to merge 1 commit into from

Conversation

amosyuen
Copy link

Make regex more specific so that clients can use the library in a folder with "src" in the name

Make regex more specific so that clients can use the library in a folder with "src" in the name
@arlenyan
Copy link

I'd also like to see this pull request merged in.

@dmiller9911
Copy link

@elijahmanor Any update on this? We are also seeing this within our demo app: https://github.com/patternfly/patternfly-react-demo-app

I made the change proposed in the PR, and it resolved the issue. Another option would be to drop babel all together and switch to commonjs modules. Node v8 (current LTS) supports everything used in this lib other than ES Modules. If those are still required, it would probably be better to switch to babel-cli instead of babel-register.

@opensas
Copy link

opensas commented Aug 13, 2019

Is this pr ever going to be accepted? it's a rather annoying issue...

@ilovelili
Copy link

the pr looks good however it has not been merged. My solutions is to use patch-package

@furf
Copy link

furf commented Feb 17, 2021

I released cross-var-src-patch for use until maintenance of this project is resumed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants