Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RollUp-Error because of This is Undefined Rewrite #387

Merged
merged 4 commits into from
Jan 12, 2018
Merged

Fix RollUp-Error because of This is Undefined Rewrite #387

merged 4 commits into from
Jan 12, 2018

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Dec 4, 2017

make it compatible with RollUp
rollup/rollup#759
parallax/jsPDF#1533

@eligrey
Copy link
Owner

eligrey commented Jan 12, 2018

See eligrey/Blob.js#56 (comment)

I don't need this.content || this, so you can just remove it entirely. Once you've made that change I will merge this.

@eligrey
Copy link
Owner

eligrey commented Jan 12, 2018

Actually, just || this is fine, and shouldn't cause any rollup errors. Don't forget to also increment the version number and timestamp at the top to 1.3.4 and 2017-01-12. Then I will merge this.

@eligrey eligrey merged commit 74f0898 into eligrey:master Jan 12, 2018
@eligrey
Copy link
Owner

eligrey commented Jan 12, 2018

Oops, I merged with this.content still. I'll fix that.

eligrey added a commit that referenced this pull request Jan 12, 2018
eligrey added a commit that referenced this pull request Jan 12, 2018
@Uzlopak Uzlopak deleted the patch-1 branch February 18, 2018 12:27
@Uzlopak
Copy link
Contributor Author

Uzlopak commented Feb 18, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants