elife_converter, set assets urls from video_data. #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re issue https://github.com/elifesciences/issues/issues/4975
Instead of relying on an old API system that used http
301
redirects for eLife video asset files, the change here populates the video nodes with pre-populated values for the jpg, mp4, ogv and webm URLs.This will correspond with a change to the
lens-elife
(https://github.com/elifesciences/lens-elife) repo that will have a helper to get video asset data from the eLife API prior to the Lens page building.A known deficiency of this method is the
video_data
will not be changed if you drag-and-drop an XML file onto an existing eLife Lens page. Due to the desire to switch to the eLife API article data, this is a compromise, rather than trying to integrate an externalGET
request into standard Lens.This should only affect eLife articles. The old URLs of eLife videos will eventually be unavailable when the legacy API helper is powered off. This may affect viewing of eLife videos in any project that displays eLife articles without the
video_data
populated.