Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elife_converter, set assets urls from video_data. #219

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Conversation

gnott
Copy link
Member

@gnott gnott commented Dec 6, 2019

Re issue https://github.com/elifesciences/issues/issues/4975

Instead of relying on an old API system that used http 301 redirects for eLife video asset files, the change here populates the video nodes with pre-populated values for the jpg, mp4, ogv and webm URLs.

This will correspond with a change to the lens-elife (https://github.com/elifesciences/lens-elife) repo that will have a helper to get video asset data from the eLife API prior to the Lens page building.

A known deficiency of this method is the video_data will not be changed if you drag-and-drop an XML file onto an existing eLife Lens page. Due to the desire to switch to the eLife API article data, this is a compromise, rather than trying to integrate an external GET request into standard Lens.

This should only affect eLife articles. The old URLs of eLife videos will eventually be unavailable when the legacy API helper is powered off. This may affect viewing of eLife videos in any project that displays eLife articles without the video_data populated.

@gnott gnott merged commit 297c999 into develop Dec 6, 2019
@gnott gnott deleted the elife-videos branch December 12, 2019 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant