Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lens throws error on JATS document with no <back> #145

Closed
pkra opened this issue Feb 25, 2016 · 4 comments
Closed

Lens throws error on JATS document with no <back> #145

pkra opened this issue Feb 25, 2016 · 4 comments

Comments

@pkra
Copy link
Contributor

pkra commented Feb 25, 2016

Seems like https://github.com/elifesciences/lens/blob/ams-fixes/converter/lens_converter.js#L959 should check if back exists before calling Article.Back.
@pkra
Copy link
Contributor Author

pkra commented Feb 25, 2016

Note, this is in the ams-fixes branch.

pkra added a commit to pkra/lens that referenced this issue Feb 25, 2016
@pkra
lens-converter: add check for back element
af383cf 
Fixes  elifesciences#145
@pkra pkra mentioned this issue Feb 25, 2016
Merged
@michael
Copy link
Member

michael commented Feb 25, 2016

👍

@CAYdenberg
Copy link

Can you close this @pkra ?

@pkra
Copy link
Contributor Author

pkra commented Mar 18, 2016

Can you close this @pkra ?

This should be closed automatically once the code is merged into master. Not sure what the policy for closing issues is though, so if @michael and @oliver---- want to close it, that's fine by me.

@gnott gnott closed this as completed Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@michael @pkra @gnott @CAYdenberg