Better account for the eLife assessment in the normalization/denormal…

…ization elifesciences/issues#9034
elifesciences · Dec 5, 2024 · 8b5674c · 8b5674c
1 parent 41b04e6
commit 8b5674c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/Model/ReviewedPreprint.php b/src/Model/ReviewedPreprint.php
@@ -55,7 +55,7 @@ public function __construct(
         Image $thumbnail = null,
         PromiseInterface $indexContent,
         int $version = null,
-        $elifeAssessment = null
+        ElifeAssessment $elifeAssessment = null
     )
     {
         $this->id = $id;

diff --git a/src/Serializer/ReviewedPreprintNormalizer.php b/src/Serializer/ReviewedPreprintNormalizer.php
@@ -82,6 +82,15 @@ public function denormalize($data, $class, $format = null, array $context = []):
             $data['image']['thumbnail'] = $this->denormalizer->denormalize($data['image']['thumbnail'], Image::class, $format, $context);
         }
 
+        if (isset($data['elifeAssessment'])) {
+            if (!isset($data['elifeAssessment']['significance'])) {
+                $data['elifeAssessment']['significance'] = [];
+            }
+            if (!isset($data['elifeAssessment']['strength'])) {
+                $data['elifeAssessment']['strength'] = [];
+            }
+        }
+
         return new ReviewedPreprint(
             $data['id'],
             $data['stage'],
@@ -204,7 +213,7 @@ public function normalize($object, $format = null, array $context = []): array
             $data['version'] = $object->getVersion();
         }
 
-        if ($object->getElifeAssessment()) {
+        if (!empty($object->getElifeAssessment())) {
             $data['elifeAssessment'] = $object->getElifeAssessment();
         }