-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a workflow to test and build the API-dummy image on github elifesciences/issues#9006 #260
Conversation
… new multi-platform image in github actions
This is a very invasive replacement. It would mean needing to update all the downstream dependencies at once - doable, but needs some time an coordination. Blocking #259 |
Why does it need to atomically affect all downstream dependencies? For example, |
Yup true. I was thinking about the automated update pipelines in Jenkins downstream, because the way I went about doing this is so invasive that I didn't keep the jenkins pipelines working. It would mean dismantling those connections, though nothing would break the the immediate, I would want to tidy up after myself so to speak. Equally, it is just work, but not easy to just "merge" when reviewed and OK. |
Noticing the Jenkinsfile deploys to a Will join the infrastructure team stand-up today to coordinate with the application development going on in |
… alfred and the new build
…not building multiplatform images
285832d
to
73c4dcf
Compare
This PR should now:
|
e36b36b
to
73c4dcf
Compare
|
||
```$sh | ||
cd /srv/api-dummy | ||
./bin/import 09560 | ||
docker compose run app ./bin/import 09560 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only task I run into problems with, perhaps a Linux file ownership issue:
[16:23:06][giorgio@Arconia:~/code/api-dummy]$ docker compose run app ./bin/import 92110
WARN[0000] /home/giorgio/code/api-dummy/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion
WARN[0000] Found orphan containers ([api-dummy-app-run-6f44d91c5293 api-dummy-composer-run-1984308df2a2 api-dummy-composer-run-73e461503125]) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.
[+] Creating 1/0
✔ Container api-dummy-composer-1 Created 0.0s
[+] Running 1/1
✔ Container api-dummy-composer-1 Started 0.2s
PHP Fatal error: Uncaught Symfony\Component\Filesystem\Exception\IOException: Failed to touch "/srv/api-dummy/bin/../data/articles/92110.json". in /srv/api-dummy/vendor/symfony/filesystem/Filesystem.php:150
Stack trace:
#0 /srv/api-dummy/bin/import(66): Symfony\Component\Filesystem\Filesystem->touch('/srv/api-dummy/...')
#1 {main}
thrown in /srv/api-dummy/vendor/symfony/filesystem/Filesystem.php on line 150
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./bin/import 09560
remains available as a workaround.
|
||
```$sh | ||
docker compose run --rm app ./project_tests.sh | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the rest of the README on Linux.
TYVM |
elifesciences/issues#9006