feat: add `wasm` target support #343

sgammon · 2023-07-30T23:01:58Z

Summary

Upgrades elide-uuid and establishes wasm target support for base module on up, weather permitting.

Changelog

feat: wasm target support in base, test, model, ssr
feat: lockfiles with lenient enforcement
feat: verification metadata with lenient enforcement
feat: build provenance (SLSA) and dependency graph
feat: unified yarn lockfile
fix: JPMS module fixes for cli
chore: update lockfiles and metadata
chore: update gradle → 8.3-rc2

sgammon · 2023-07-30T23:44:40Z

packages/base/src/commonTest/kotlin/elide/util/Base64Test.kt

-      "YWJjMTIzMTIzMQ",
+      "YWJjMTIzMTIzMQ==",


this was wrong in the test. i was not aware that "urlsafe" base64 was different from "padless" base64. i am now.

sgammon · 2023-07-30T23:44:54Z

packages/base/src/jsMain/kotlin/elide/util/Base64.kt

-    return this.encodeToString(string).replace("=", "")
+    return kotlin.io.encoding.Base64.UrlSafe.encode(string.encodeToByteArray())


delegating to kotlin stdlib for base64 on most platforms now

sgammon · 2023-07-30T23:45:45Z

packages/base/src/wasmMain/kotlin/elide/runtime/Logging.kt

+    TODO("not yet implemented")
+  }


needs implementation

sgammon · 2023-07-30T23:46:27Z

packages/cli/build.gradle.kts

  "-H:+UseContainerSupport",
  "-H:+UseCompressedReferences",
+  "-H:+AllowJRTFileSystem",


note to self: audit flags from jshell sample before merge

socket-security · 2023-07-31T04:17:32Z

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
express	4.18.2	network, filesystem, environment	`+42`	2.18 MB	dougwilson
@mdx-js/mdx	2.3.0...2.2.1	None	`+1/-4`	150 kB	wooorm

Signed-off-by: Sam Gammon <[email protected]>

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

- feat: `wasm` target support - feat: initial wasm model logic (probably broken) - chore: refactor `Model` annotation to avoid split packages Breaking change: `Model` annotation path Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

- feat: multiplatform build support in `proto-core` - feat: multiplatform build support in `proto-kotlinx` Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

Signed-off-by: Sam Gammon <[email protected]>

[StepSecurity] Apply security best practices Signed-off-by: StepSecurity Bot <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

Signed-off-by: Sam Gammon <[email protected]>

codecov · 2023-07-31T07:17:15Z

Codecov Report

❗ No coverage uploaded for pull request base (release/alpha4@57dad5e). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release/alpha4     #343   +/-   ##
=================================================
  Coverage                  ?   44.68%           
=================================================
  Files                     ?      280           
  Lines                     ?     9466           
  Branches                  ?     1324           
=================================================
  Hits                      ?     4230           
  Misses                    ?     4964           
  Partials                  ?      272

Flag	Coverage Δ
jvm	`44.68% <0.00%> (?)`
lib	`45.80% <0.00%> (?)`
substrate	`0.00% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57dad5e...0be248f. Read the comment docs.

sgammon

good enough to merge

sgammon · 2023-07-31T08:10:18Z

packages/base/build.gradle.kts

+
+    wasm {
+        nodejs()
+        d8()


sgammon · 2023-07-31T08:10:53Z

packages/cli/src/main/kotlin/elide/tool/cli/control/EspressoExecutionControlProvider.kt

+class EspressoExecutionControlProvider: ExecutionControlProvider {
+  override fun name(): String {
+    TODO("Not yet implemented")
+  }
+
+  override fun generate(env: ExecutionEnv?, parameters: MutableMap<String, String>?): ExecutionControl {
+    TODO("Not yet implemented")


needs to be caught in a test, and addressed with impl before release

sgammon added feature Large PRs or issues with full-blown features 🚧 WIP Works-in-progress. Blocks merge wasm Features and PRs that relate to WebAssembly labels Jul 30, 2023

sgammon added this to the Release R2: Alpha 4 milestone Jul 30, 2023

sgammon self-assigned this Jul 30, 2023

github-actions bot added module:base Changes and issues relating to the Elide `base` module platform:jvm PRs and issues relating to JVM support. platform:browser PRs and issues relating to browser support. labels Jul 30, 2023

sgammon commented Jul 30, 2023

View reviewed changes

sgammon changed the title ~~feat: add wasm target support to base module (early)~~ feat: add wasm target support Jul 31, 2023

sgammon mentioned this pull request Jul 31, 2023

Release: 1.0-v3-alpha4-b9 #325

Merged

37 tasks

sgammon force-pushed the feat/wasm branch from 22e76e6 to c212782 Compare July 31, 2023 05:10

sgammon added 17 commits July 30, 2023 22:12

feat: add wasm target support to base module (early)

6f3fe8c

Signed-off-by: Sam Gammon <[email protected]>

chore: upgrade to release of elide-uuid

6b6ce53

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: general build cleanup from past several commits

0a18fbc

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: update kjs yarn lock

386fa0c

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

fix: module opens args after jline dep fix

d053dda

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: general build cleanup for push

e7cdbdf

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: setup for jshell via espresso

7473f06

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: lenient dependency locking and verification by default

7bdc0f8

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

fix: use wasm repositories codebase wide

c5440a1

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: drop kotter, add capnproto

e3abb5a

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: merged yarn.lock for monorepo

f7306f7

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

fix: missing jshell module for cli

3202b6f

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

feat: transition proto-core and proto-kotlinx to mpp

f5f1c4f

- feat: multiplatform build support in `proto-core` - feat: multiplatform build support in `proto-kotlinx` Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

feat: wasm target support for ssr module

2cf5daf

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: add empty proto-capnp module

29b3a31

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: update yarn lock

bf0ad65

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

sgammon and others added 13 commits July 30, 2023 22:12

chore: activate dependency locking

40bd767

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: add verification metadata

ac170f5

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

fix: drop outdated KotlinJvmTest patch

f7ad1bb

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

feat(ci): report build provenance and dependency graph

c46bd63

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: upgrade gradle → 8.3-rc2

1f7102a

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: update lockfiles, verification metadata

af5b63f

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

chore: enable configuration cache

2e32f86

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

feat: execution controller for jshell (coming soon)

4f87552

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

fix: ci reporting for provenance

6a5dea4

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

fix: yarn lock ci step

892dd09

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

fix: add api pin for proto-capnp

f67a7a3

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

fix: disable config cache (as always, it's broken)

cc3f09a

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

fix: update proto module api pins

83d2267

Signed-off-by: Sam Gammon <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

sgammon force-pushed the feat/wasm branch 2 times, most recently from c69c881 to 42f4ffa Compare July 31, 2023 05:46

sgammon added 2 commits July 30, 2023 23:51

fix: build error with atomicfu runtime in ssr

cafa140

Signed-off-by: Sam Gammon <[email protected]>

fix: apply another fix for atomicfu issue

792dee5

Signed-off-by: Sam Gammon <[email protected]>

sgammon force-pushed the feat/wasm branch from 9e4b4c0 to 2c37c2c Compare July 31, 2023 06:51

step-security-bot and others added 2 commits July 30, 2023 23:52

feat: security hardening for ci

10ab283

[StepSecurity] Apply security best practices Signed-off-by: StepSecurity Bot <[email protected]> Signed-off-by: Sam Gammon <[email protected]>

fix: quoting of action coordinates

0be248f

Signed-off-by: Sam Gammon <[email protected]>

sgammon force-pushed the feat/wasm branch from 2c37c2c to 0be248f Compare July 31, 2023 06:52

sgammon marked this pull request as ready for review July 31, 2023 08:09

sgammon commented Jul 31, 2023

View reviewed changes

sgammon removed the 🚧 WIP Works-in-progress. Blocks merge label Jul 31, 2023

sgammon merged commit c5181d1 into release/alpha4 Jul 31, 2023

sgammon deleted the feat/wasm branch July 31, 2023 08:26

sgammon mentioned this pull request Sep 13, 2023

Tracking: Alpha Launch #398

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `wasm` target support #343

feat: add `wasm` target support #343

sgammon commented Jul 30, 2023 •

edited by pull-request-badge bot

Loading

sgammon Jul 30, 2023

sgammon Jul 30, 2023

sgammon Jul 30, 2023

sgammon Jul 30, 2023

socket-security bot commented Jul 31, 2023

codecov bot commented Jul 31, 2023

sgammon left a comment

sgammon Jul 31, 2023

sgammon Jul 31, 2023

		return this.encodeToString(string).replace("=", "")
		return kotlin.io.encoding.Base64.UrlSafe.encode(string.encodeToByteArray())

feat: add wasm target support #343

feat: add wasm target support #343

Conversation

sgammon commented Jul 30, 2023 • edited by pull-request-badge bot Loading

Summary

Changelog

sgammon Jul 30, 2023

Choose a reason for hiding this comment

sgammon Jul 30, 2023

Choose a reason for hiding this comment

sgammon Jul 30, 2023

Choose a reason for hiding this comment

sgammon Jul 30, 2023

Choose a reason for hiding this comment

socket-security bot commented Jul 31, 2023

codecov bot commented Jul 31, 2023

Codecov Report

sgammon left a comment

Choose a reason for hiding this comment

sgammon Jul 31, 2023

Choose a reason for hiding this comment

sgammon Jul 31, 2023

Choose a reason for hiding this comment

feat: add `wasm` target support #343

feat: add `wasm` target support #343

sgammon commented Jul 30, 2023 •

edited by pull-request-badge bot

Loading