Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added constexpr if #61

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Added constexpr if #61

merged 1 commit into from
Nov 2, 2023

Conversation

matbech
Copy link
Contributor

@matbech matbech commented May 20, 2022 •
edited
Loading

Adds constexpr if

This fixes #60

@matbech matbech mentioned this pull request May 20, 2022
Closed
@matbech
Copy link
Contributor Author

matbech commented May 20, 2022 •
edited
Loading

C++17 is required for constexpr if.

@matbech matbech changed the title Added constexpr Added constexpr if May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/locale.cpp 51.94% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@eliaskosunen eliaskosunen merged commit 7e8007a into eliaskosunen:master Nov 2, 2023
108 checks passed
@eliaskosunen
Copy link
Owner

Rebased, signed, squashed, and merged, with modifications. Thank you!

@matbech matbech deleted the patch-1 branch November 2, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warning C4127: conditional expression is constant
2 participants
@matbech @eliaskosunen