Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change empire name in exported timelapse to medium white on black for readability #93

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

chennin
Copy link
Contributor

@chennin chennin commented Dec 24, 2022

I find the current text color (almost the same as the empire fill color) to be hard to read. This takes a small part of #80 that isn't related to empire colors. It changes the empire name text on the timelapse export to a medium-size white with black outline. I found that the most readable, although I'm slightly sad to not be using the empire color in the text.

Image: https://i.imgur.com/1JIGcej.gif (wait til 2246)

Here is a comparison of several options considered: https://imgur.com/a/shYAEMS

@eliasdoehne
Copy link
Owner

Yea I guess it's hard to ensure readability when the empire colors can be very dark or very bright. I'm ok with the change, maybe we can reconsider this later once we use the in-game colors for empires

@eliasdoehne eliasdoehne merged commit d513c9b into eliasdoehne:master Jan 5, 2023
@chennin chennin deleted the add_text_outline branch January 5, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants