Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select system instructional text not displayed, and split selected system ledger link into system and country #175

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

MichaelMakesGames
Copy link
Collaborator

@MichaelMakesGames MichaelMakesGames commented Dec 18, 2024

The "Click the map to select a system" text was being almost immediately hidden upon loading the page, due to early return of "" in the callback

While fixing that, I made an enhancement to split the link for the selected system into separate links for the system and country ledger pages, instead of just one for the system

@MichaelMakesGames MichaelMakesGames merged commit 723eff9 into master Dec 18, 2024
3 checks passed
@MichaelMakesGames MichaelMakesGames deleted the select-system-improvements branch December 18, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant