Fix some name renderer errors; fix errors parsing some modded saves #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw looks like the dashboard is working with the Stellaris 3.10 update. I tested on this branch, but I assume master works too. |
|
Nice! I think the name renderer change overlaps a bit with changes in my other branch, but I'll reconcile it when I merge mine, probably some time next weekend. Good to hear that it still seems to work with the new patch! I will also run a few games in observer mode for some decades to hopefully catch any breaking issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118
Also fixes some issues parsing loc files and rendering names