Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic system tray notifications support in plain TTY mode #2528

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

unxed
Copy link
Contributor

@unxed unxed commented Nov 25, 2024

planned to also add ESC sequences for kitty and iTerm2, but do not understand how to send them from here

see #1101

…ences for kitty and iTerm2, but do not understand how to send them from here
@elfmz
Copy link
Owner

elfmz commented Dec 1, 2024

1 Зачем преобразовывать строки если можно в формат строке просто указать %ls? Да и голый snprintf тут не нужен, есть StrPrintf
2 запускать лучше notify.sh, для чего GetNotifySH и его обвязку (fork/execl) вытащить куданить из wx в общий код

@elfmz elfmz merged commit 7ec756b into elfmz:master Dec 1, 2024
2 checks passed
@unxed
Copy link
Contributor Author

unxed commented Dec 1, 2024

Ага, спасибо! Ещё вот это бы
#2537

@unxed unxed deleted the tty_notif branch December 7, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants