Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle keybindings and confirmation in the indicator #270

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Handle keybindings and confirmation in the indicator #270

merged 5 commits into from
Jan 5, 2024

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Dec 31, 2023 •
edited
Loading

Fixes #9
Fixes #13

Todo:

  • Make shortcuts customizable

This was referenced Dec 31, 2023
Closed
Closed
Closed
Closed
@lenemter lenemter marked this pull request as ready for review December 31, 2023 12:21
@lenemter lenemter requested a review from a team December 31, 2023 12:21
@lenemter lenemter mentioned this pull request Dec 31, 2023
Merged
@danirabbit danirabbit requested a review from Marukesu January 2, 2024 19:01
danirabbit
danirabbit approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixes the issue! Requested @Marukesu since it seems like he had some opinions on previous branches :)

Marukesu
Marukesu reviewed Jan 3, 2024
View reviewed changes
src/Indicator.vala Outdated Show resolved Hide resolved
Marukesu
Marukesu approved these changes Jan 3, 2024
View reviewed changes
Copy link

@Marukesu Marukesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't forget to update the switchboard plug to use the new keys instead of the GSD ones.

@lenemter

This comment was marked as resolved.

Sign in to view
@lenemter lenemter requested a review from a team January 4, 2024 03:28
@danirabbit danirabbit merged commit fb22657 into master Jan 5, 2024
4 checks passed
@danirabbit danirabbit deleted the lenemter/handle-keybindings branch January 5, 2024 20:01
@lenemter lenemter removed the request for review from a team January 6, 2024 03:50
@lenemter lenemter mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marukesu Marukesu Marukesu approved these changes

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OS 8
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move confirmation notifications to their relevant indicators Suppress confirmation notifications while open
3 participants
@lenemter @danirabbit @Marukesu