Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample: Drop support for translation #323

Closed
wants to merge 1 commit into from

Conversation

ryonakano
Copy link
Member

This is just a sample so no need to mark these strings translatable.

@tintou
Copy link
Member

tintou commented Sep 20, 2024

Why not keeping it like this?

@ryonakano
Copy link
Member Author

Either is fine, but since we don't provide translations of this file in the switchboard itself, I thought calling _() here is useless.

@ryonakano
Copy link
Member Author

After reconsideration I'll close the PR because those who want to build a new plug based on the sample plug would take the trouble to add _() to display_name and description. Even though calling _() by this plug itself is useless, but by keeping it as it is, people just need to edit strings inside _().

@ryonakano ryonakano closed this Sep 23, 2024
@ryonakano ryonakano deleted the ryonakano/sample-no-translate branch September 23, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants