Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if Granite.accel_to_string returns null #463

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Check if Granite.accel_to_string returns null #463

merged 2 commits into from
Aug 17, 2023

Conversation

lenemter
Copy link
Member

Avoid crash when there are incorrect keyboard shortcuts.

@lenemter lenemter requested a review from a team August 16, 2023 18:05
@lenemter lenemter mentioned this pull request Aug 16, 2023
Merged
jeremypw
jeremypw approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issue when invalid shortcut introduced using dconf-editor. Code looks good. Thanks.

@jeremypw jeremypw merged commit a66bb8a into master Aug 17, 2023
@jeremypw jeremypw deleted the check-return-value-of-accel-to-string branch August 17, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenemter @jeremypw