InputMethod: Fix ProgressDialog is not used #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProgressDialog is destroyed when the progress become 100% or cancel button is pressed, so we don't need to call destroy() here
jeremypw
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
This works as expected and the code looks good.
There needs to be a solution for the fact that after installing a new engine it does not appear in the list of engines and cannot be used until the user logs out and in again.
If it cannot be automatic then a message informing the user of this is needed.
However that is outside the scope of this PR, I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added InputMethod view in #287, I forgot to bring the logic to show the progress dialog from my InputMethod Plug. Thus, this dialog has been a died code since then and never been shown to user. This PR adds that logic and show the progress dialog while installing input method engine: