Handle Ryzen CPU and AMD GPU vendor string and break on first regex match #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to have "AMD®" (the registered trademark symbol) prefixed on the GPU (and CPU?) vendor string displayed? |
|
@lenemter I update the PR with an addition regex - could you see if it cleans up your iGPU vendor string? (post updated screenshot)? |
lenemter
approved these changes
Sep 28, 2022
|
® is too small in this font, should we keep it? |
|
Thanks @lenemter ! I will let others (core devs) comment/merge as they see fit :-) |
Seems OK to me (there is in existing code as well) but I don't have opinion either way. |
ryonakano
approved these changes
Oct 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixups to handle specific Ryzen CPU and AMD GPU vendor strings in the regex replacement cleanup method.
Also, break after the first regex match, so the replacement strings are in order of preference now.
Before: (note the lowercasing of the cpu string and lengthy gpu string)
After: (note the generic gpu string part matched, instead of the "RX 570" trailer because the actual gpu is an RX 580)